Skip to content

Add an experiment to disable pip build isolation #37331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shunping wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add an experiment to disable pip build isolation #37331

shunping wants to merge 2 commits into from
+20 −0

Conversation

@shunping
Copy link
Collaborator

@shunping shunping commented Jan 16, 2026 •
edited
Loading

Background:

Pip 25.3 removed non-PEP 517 package build support(https://discuss.python.org/t/announcement-pip-25-3-release/104550), meaning that by default installing a source distribution will first build the wheel in an isolated environment and then install the wheel.

Some users reported problems when using Beam Python SDK docker container in an environment that have no internet access, because building the wheel requires downloading pacakages from pip.

Solution:

Add an experiment option pip_no_build_isolation to disable build isolation when installing package with pip in boot.go. Essentially, when this experiment is used, we will append --no-build-isolation to the pip install command.

Internal bug id: 475376468

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 16, 2026

Summary of Changes

Hello @shunping, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the Python container's boot logic to adjust how Python packages are installed, specifically targeting workflow tarballs. The primary goal is to disable pip's build isolation feature by default for these installations, which can sometimes cause issues or overhead. To maintain configurability, an environment variable has been added, allowing users to easily re-enable build isolation if their specific workflow requires it. This change provides a more controlled and potentially more efficient installation environment for Python workflows.

Highlights

  • Default Build Isolation Change: Build isolation for workflow tarball installations is now disabled by default, aiming to streamline the installation process.
  • Environment Variable for Override: An environment variable, USE_BUILD_ISOLATION_FOR_WORKFLOW, has been introduced. Setting this variable will re-enable build isolation for workflow tarball installations, providing flexibility for specific use cases.
  • Refactored pipInstallPackage: The pipInstallPackage function now accepts a useBuildIsolation boolean parameter, allowing explicit control over whether the --no-build-isolation flag is passed to pip install commands. Other pip install calls (for extra packages and SDK) explicitly enable build isolation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@shunping
Copy link
Collaborator Author

shunping commented Jan 16, 2026

R: @tvalentyn

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

tvalentyn
tvalentyn approved these changes Jan 16, 2026
View reviewed changes
@tvalentyn tvalentyn mentioned this pull request Jan 16, 2026
Merged
3 tasks
@tvalentyn
Copy link
Contributor

tvalentyn commented Jan 20, 2026

Thought a bit more about this, people who use --extra_package might also be affected by pip forcing build isolation. I'll run some queries to see usage patterns.

@shunping
Copy link
Collaborator Author

shunping commented Jan 20, 2026

Thought a bit more about this, people who use --extra_package might also be affected by pip forcing build isolation. I'll run some queries to see usage patterns.

Good point. Given build isolation primarily affects non-wheel packages, users passing source tarballs / zip files through --extra_package could definitely see the same problem here.

@shunping shunping changed the title Disable build isolation for workflow tarball by default Add an experiment to disable pip build isolation Jan 21, 2026
tvalentyn
tvalentyn reviewed Jan 22, 2026
View reviewed changes
sdks/python/container/boot.go
}

pipNoBuildIsolation = false
if strings.Contains(options, "pip_no_build_isolation") {
Copy link
Contributor

@tvalentyn tvalentyn Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make the check more narrow (e.g. to find experiments, and check the experiments) instead of finding substrings in the entire blob of options? I worry this pattern might be repeated in some other context where it might cause a collision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tvalentyn tvalentyn tvalentyn approved these changes

Assignees

No one assigned

Labels

docker python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shunping @tvalentyn